fix(icons): change the address of font files #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fail to load font resource with 404 occur on browsing a address like abc.com/yy/mm/dd/name.html change the directory of fontawesome-*.eot
|
@cubesky I think we need to import font-awesome using relative url. |
|
@neoFelhz I think we use CDN instead better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Description
Bug Description :
request the wrong address like abc.com/yy/mm/dd/font/fontawesome-.eot.
fail to load font resource with 404 under the scheme of 'isolation'.
occur when browsing an address like abc.com/yy/mm/dd/name/
but abc.com/ can still work with loading abc.com/font/awesome-.eot.
Solution :
change the directory of '../font/fontawesome-.eot' into '/font/fontawesome-.eot' .
Verification steps
visit abc.com/yy/mm/dd/title with scheme of 'isolation' and inspect the sidebar icons of google+, facebook, twitter etc.
change the directory of fontawesome and visit it again.