Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISC] Having IbisML closer to sklearn #141

Closed
wants to merge 1 commit into from

Conversation

gtauzin
Copy link

@gtauzin gtauzin commented Aug 25, 2024

Following discussion in #135, I thought I would give it a try and set up a wrapper of IbisML steps as fully-fledged sklearn transformers so that they follow more closely the sklearn API.

Running the adapted example notebook, you can already check that :

  • An ibis step wrapped into a transformer within the sklearn pipeline does not eagerly execute;
  • get_params works as intended.

I'll edit this msg later with a list of more detailed points.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 35.29412% with 22 lines in your changes missing coverage. Please review.

Project coverage is 84.08%. Comparing base (80881f8) to head (e2f99c6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ibis_ml/estimators.py 33.33% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   84.94%   84.08%   -0.87%     
==========================================
  Files          26       27       +1     
  Lines        1920     1954      +34     
==========================================
+ Hits         1631     1643      +12     
- Misses        289      311      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gtauzin
Copy link
Author

gtauzin commented Sep 13, 2024

Closing as @jcrist made it clear that having Steps as sklean transformer would not be a good idea in #135 .

@gtauzin gtauzin closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants