IBX-8138: [Rector] Applied rules from Symfony 5 Rector set lists #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied rules: * AddReturnTypeDeclarationRector * RenameClassConstFetchRector * ResponseStatusCodeRector
Applied rules: * ResponseStatusCodeRector
Applied rules: * RenameClassConstFetchRector
|
konradoboza
approved these changes
Jul 22, 2024
| @@ -4,17 +4,18 @@ | |||
| * @copyright Copyright (C) Ibexa AS. All rights reserved. | |||
| * @license For full copyright and license information view LICENSE file distributed with this source code. | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
I guess it's not covered by existing Rector rules, but would be good to add declare(strict_types=1); whenever possible as we touch such amount of codebase...
There was a problem hiding this comment.
strict_types do have an effect on the execution, so we'd want this done in more controlled fashion than just adding it everywhere.
There was a problem hiding this comment.
whenever possible
I am not talking about introducing a specific rector, but decreasing amount of code to touch on our way to Sf6 whenever a low-hanging fruit kind of situation presents itself.
adamwojs
approved these changes
Jul 22, 2024
Steveb-p
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Applied rules from Symfony 5 Rector set lists.
For QA:
No QA needed. Regression tests should be enough.
Documentation:
This is code refactoring without behavior change. No documentation changes needed.