Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding blackfire config (as a comment) specific to varnish #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adding blackfire config (as a comment) specific to varnish #29

wants to merge 1 commit into from

Conversation

flovntp
Copy link

@flovntp flovntp commented Aug 4, 2022 •
edited by konradoboza
Loading

Question Answer
JIRA issue Blackfire Ticket #24331
Type Improvement
Target version main
BC breaks no
Doc needed yes

@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@flovntp
Copy link
Author

flovntp commented Aug 5, 2022

Please also add those lines in .platform/varnish.vcl as it is there where i needed to add those lines to solve my Varnish issue using Blackfire tool.

@konradoboza
Copy link
Contributor

@flovntp thank you for the contribution and sorry for getting back to you so late. Could you please elaborate a bit on this change? The linked Blackfire ticket is not available for us to check. Also, rebase against current main branch would be welcomed since this PR is a bit old now.

@konradoboza konradoboza requested review from alongosz, ViniTou and a team July 28, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz Awaiting requested review from alongosz

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees

@damianz5 damianz5

@alongosz alongosz

@ViniTou ViniTou

Labels
Investigation 🕵️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flovntp @konradoboza @damianz5 @alongosz @ViniTou