-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8824: The popup for custom tags with multiple fields is not scrollable #183
Conversation
src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-ui.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-ui.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-ui.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/CKEditor/custom-tags/inline-custom-tag/inline-custom-tag-ui.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/CKEditor/custom-tags/inline-custom-tag/inline-custom-tag-ui.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/CKEditor/custom-tags/inline-custom-tag/inline-custom-tag-ui.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/CKEditor/custom-tags/inline-custom-tag/inline-custom-tag-ui.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I've found an issue:
- Go to creating an article
- Paste some text into richtext field
- Somewhere in the middle insert added custom tag
- Don't fill the fields in CT, just click save
- Click settings button and the edit button in custom tag
- Try to scroll to the top
Actual result: Top of the custom tag is still covered. See attachment, please.
https://github.com/user-attachments/assets/a77eaf4e-016c-4a3e-829b-5dad652fd586
Note: 4.6 CI fix is pending review, via #184 |
Still covers the very last element in menu when it's displayed below custom tag... 😅 Screen.Recording.2024-09-17.at.15.43.55.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I've found an issue:
- Go to creating an article
- Paste some text into richtext field
- Enter distraction-free mode.
- Somewhere in the middle insert added custom tag
- Try to scroll to the top
Actual result: A window with a scrollbar appears in the wrong place. See attachment, please.
Nagranie.z.ekranu.2024-09-18.o.14.58.31.mov
@@ -19,6 +19,22 @@ class IbexaCustomTagUI extends Plugin { | |||
this.addCustomTag = this.addCustomTag.bind(this); | |||
|
|||
this.isNew = false; | |||
this.lastClassListValue = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver/observe#attributeoldvalue
there is dedicated option for it in mutation observer :)
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot reproduce
Hi, I've found new an issue:
The popup disappears when we start scrolling the page up and down quickly. The error occurs in both regular and distraction-free mode.
1. Go to creating an article
2. Paste some text into richtext field
3. Somewhere in the middle insert added custom tag
4. Scroll the page up and down quickly.
Please see the attachment:
https://github.com/user-attachments/assets/1d7df575-1bfd-45fd-b2f2-605407d5e233
Merged up:
|
Description:
For QA:
Documentation: