Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6310: Separated text extraction logic from SearchField class #119

Merged
merged 4 commits into from
Aug 18, 2023
Merged

IBX-6310: Separated text extraction logic from SearchField class #119

merged 4 commits into from
Aug 18, 2023

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Aug 8, 2023

Question Answer
JIRA issue IBX-6310
Improvement yes
New feature no
Target version main
BC breaks no
Tests pass yes
Doc needed no

Moved text extraction logic from \Ibexa\FieldTypeRichText\FieldType\RichText\SearchField to \Ibexa\FieldTypeRichText\RichText\TextExtractor. I initially explored the idea of creating new Converter with text output format which would let me nicely use XSLT processor to convert the value but Coverters are designed to transform XML to XML. It wasn't going to work. So I simply moved the logic and updated the tests.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@webhdx webhdx requested a review from a team August 8, 2023 11:46
@webhdx webhdx self-assigned this Aug 8, 2023
alongosz
alongosz reviewed Aug 8, 2023
View reviewed changes
src/lib/RichText/TextExtractor.php Outdated Show resolved Hide resolved
src/lib/RichText/TextExtractor.php Outdated Show resolved Hide resolved
@alongosz alongosz requested a review from a team August 8, 2023 12:00
@webhdx webhdx requested a review from alongosz August 8, 2023 12:58
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@webhdx webhdx requested review from alongosz and a team August 10, 2023 09:29
@micszo micszo self-assigned this Aug 18, 2023
micszo
micszo approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with sanities on LSE, Solr and Elastic.

QA Approved on Ibexa Commerce 4.6.x-dev.

@micszo micszo removed their assignment Aug 18, 2023
@webhdx webhdx merged commit 26c30dc into main Aug 18, 2023
22 checks passed
@webhdx webhdx deleted the IBX-6310-Separate-text-extraction-logic-from-SearchField-class-in-RichText-FieldType branch August 18, 2023 13:28
@micszo micszo mentioned this pull request Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@micszo micszo micszo approved these changes

@ciastektk ciastektk ciastektk approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@alongosz alongosz

@webhdx webhdx

@konradoboza konradoboza

Labels
Improvement QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@webhdx @alongosz @ciastektk @micszo @ViniTou @konradoboza