Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8066: Added dispatch event "ibexa-inputs:added" for new item #44

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

mateuszdebinski
Copy link
Contributor

🎫 Issue IBX-8066

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Apr 3, 2024
@mateuszdebinski mateuszdebinski requested a review from a team April 3, 2024 12:30
@mateuszdebinski mateuszdebinski self-assigned this Apr 3, 2024
@mateuszdebinski mateuszdebinski changed the base branch from main to 4.5 April 3, 2024 12:30
Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamwojs
Copy link
Member

adamwojs commented Apr 5, 2024

Do we have similar events for e.g. removing item ?

@mateuszdebinski
Copy link
Contributor Author

mateuszdebinski commented Apr 5, 2024

Do we have similar events for e.g. removing item ?

as far as I know, no (when it comes to removing an item), because when adding new items we want to add appropriate listeners to the newly added inputs. We have two events starting with "ibexa-inputs":

ibexa-inputs:added
ibexa-inputs:recalculate-styling

@ciastektk ciastektk merged commit f98a3d0 into 4.5 Apr 12, 2024
14 of 15 checks passed
@ciastektk ciastektk deleted the IBX-8066_can_not_clear_new_input branch April 12, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants