IBX-8006: Fixed matrix field resolving based on content's origin #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webhdx
approved these changes
Mar 22, 2024
mikadamczyk
approved these changes
Mar 22, 2024
|
ViniTou
approved these changes
Mar 22, 2024
Steveb-p
approved these changes
Mar 22, 2024
Nattfarinn
approved these changes
Mar 22, 2024
tomaszszopinski
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.ibexa.co/browse/IBX-8006
Fixes regression introduced by https://github.com/ibexa/product-catalog/pull/1144.
It orbits around resolving content based on CT containing
matrixfieldtype. Registering two resolvers withMatrixFieldValuealias resulted in overriding the first loaded one (Ibexa\FieldTypeMatrix\GraphQL\FieldValueResolver) with the second (Ibexa\ProductCatalog\GraphQL\Resolver\MatrixFieldType\FieldValueResolver) which in turn blowed up when content based on CT withmatrixwas created.The idea is to loosen up the type coming to the original resolver and introduce strategies allowing us to properly fetch content both from
Ibexa\GraphQL\Value\ItemandIbexa\Contracts\ProductCatalog\Values\ContentAwareProductInterface(tackled within the companion PR https://github.com/ibexa/product-catalog/pull/1154).