IBX-4064: Search page #1860
Open
IBX-4064: Search page #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be strictly more than 10 but hit count is not known here
Avoid to lost search by surprise if reloading. Allow to share search results.
If removed, it searches in all versions.
adriendupuis
force-pushed
the
search-page
branch
from
efca554
to
5c1108b
Compare
adriendupuis
commented
Feb 2, 2023
docs/js/custom.js
Outdated
| } | ||
| let href = '/en/' + branchName + '/search_results/#q=' + encodeURI($(/*this.inputSelector*/'#search_input').val()) + '&p=1'; | ||
| link.attr('href', href).show(); | ||
| if (hits.length < 10/*hitsPerPage*/) { |
There was a problem hiding this comment.
hits.length == hitsPerPage means that there are hitsPerPage or more results; hits.length > hitsPerPage can't happen. So we can only be sure that the link must be hidden if there is less than hitsPerPage results.
adriendupuis
commented
Feb 17, 2023
When the whole text is highlight, the hover wasn't visible
instantsearch.js:29 Uncaught TypeError: Cannot read properties of null (reading '1')
at instantsearch.js:29:65
at instantsearch.js:229:3
It helps the user to manipulate the browser URL. Some browser like Chrome doesn't react when the hash/anchor is modified by hand but does when the search/GET is. notice: `?q=` is intercepted by the top-right search input box so full page param has to be renamed. https://developer.mozilla.org/en-US/docs/Web/API/History/pushState#change_a_query_parameter
Useful for dropdown debug when true, it change the searchbox background from white to black even when set to false.
Use relative base_url instead of absolute config.site_url
# Conflicts: # docs/css/custom.css
If I'm correct, "¶" is now removed at indexation time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See all resultslink at bottom of search dropdown menuTo wrap the search page into the doc layout, I use https://www.mkdocs.org/user-guide/writing-your-docs/#meta-data
Preview: https://ez-systems-developer-documentation--1860.com.readthedocs.build/en/1860/search_results/?sq=Content&p=5
Checklist