Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8470: Upgraded codebase to Symfony 6 #125

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

IBX-8470: Upgraded codebase to Symfony 6 #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
092df36
[Composer] Forced PHP >= 8.3
alongosz Nov 15, 2024
333d20a
[Git] Added missing src/contracts directory
alongosz Nov 15, 2024
43a8286
Bumped Symfony packages requirements to ^6.4
alongosz Nov 15, 2024
12e9755
[TMP] Required Symfony 6 dev branches of Ibexa packages
alongosz Nov 15, 2024
e35515c
[Composer] Bumped psy/psysh to ^0.12.4 which supports Symfony 6
alongosz Nov 15, 2024
832f0aa
[Composer] Dropped dependency on ci-scripts standalone app
alongosz Nov 15, 2024
7b93b3d
[Composer] Dropped abandoned behat/mink-goutte-driver
alongosz Nov 15, 2024
230ac7e
[Composer] Dropped direct dependency on PHP CS Fixer
alongosz Nov 15, 2024
8c04c3c
Aligned RetryChoiceListFactory with Symfony 6
alongosz Nov 15, 2024
597dd27
[Tests] Aligned form tests with Symfony 6
alongosz Nov 15, 2024
8d74c71
[Tests] Aligned codebase with upgraded version of psy/psysh
alongosz Nov 15, 2024
bc1a50e
[PHPStan] Removed resolved issues
alongosz Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 15 additions & 18 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,15 @@
"ezsystems/behatbundle": "*"
},
"require": {
"php": "^7.4 || ^8.0",
"php": ">=8.3",
"ext-json": "*",
"behat/behat": "^3.13",
"behat/mink-goutte-driver": "^1.2",
"behat/mink-selenium2-driver": "^1.4",
"bex/behat-screenshot": "^2.1",
"dmore/behat-chrome-extension": "^1.3",
"dmore/chrome-mink-driver": "^2.7",
"ezsystems/behat-screenshot-image-driver-cloudinary": "^1.1@dev",
"ibexa/core": "~5.0.0@dev",
"ibexa/core": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"friends-of-behat/mink": "^1.8",
"friends-of-behat/mink-browserkit-driver": "^1.4",
"friends-of-behat/mink-extension": "^2.4",
Expand All @@ -25,30 +24,28 @@
"liuggio/fastest": "^1.11",
"php-http/client-common": "^2.1",
"phpunit/phpunit": "^8.5 || ^9.0 || ^10.0",
"symfony/config": "^5.0",
"symfony/console": "^5.0",
"symfony/dependency-injection": "^5.0",
"symfony/lock": "^5.0",
"symfony/stopwatch": "^5.2",
"symfony/http-kernel": "^5.0",
"symfony/process": "^5.4",
"symfony/property-access": "^5.0",
"symfony/yaml": "^5.0",
"psy/psysh": "^0.10.8",
"symfony/config": "^6.4",
"symfony/console": "^6.4",
"symfony/dependency-injection": "^6.4",
"symfony/lock": "^6.4",
"symfony/stopwatch": "^6.4",
"symfony/http-kernel": "^6.4",
"symfony/process": "^6.4",
"symfony/property-access": "^6.4",
"symfony/yaml": "^6.4",
"psy/psysh": "^0.12.4",
"oleg-andreyev/mink-phpwebdriver": "<1.3.3",
"oleg-andreyev/mink-phpwebdriver-extension": "^1.0",
"symfony/form": "^5.4"
"symfony/form": "^6.4"
},
"require-dev": {
"ibexa/code-style": "~2.0.0",
"friendsofphp/php-cs-fixer": "^3.0",
"ibexa/ci-scripts": "^0.2@dev",
"ibexa/doctrine-schema": "~5.0.0@dev",
"ibexa/doctrine-schema": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"mikey179/vfsstream": "^1.6",
"phpstan/phpstan": "^1.10",
"phpstan/phpstan-phpunit": "^1.3",
"phpstan/phpstan-symfony": "^1.3",
"symfony/phpunit-bridge": "^6.3"
"symfony/phpunit-bridge": "^6.4"
},
"autoload": {
"psr-4": {
Expand Down
210 changes: 0 additions & 210 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
parameters:
ignoreErrors:
-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Command\\\\CreateExampleDataCommand\\:\\:configure\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/Command/CreateExampleDataCommand.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Command\\\\CreateExampleDataManagerCommand\\:\\:createProcesses\\(\\) has no return type specified\\.$#"
count: 1
Expand Down Expand Up @@ -40,16 +35,6 @@ parameters:
count: 1
path: src/bundle/Command/CreateExampleDataManagerCommand.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Command\\\\CreateLanguageCommand\\:\\:configure\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/Command/CreateLanguageCommand.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Command\\\\TestSiteaccessCommand\\:\\:configure\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/Command/TestSiteaccessCommand.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Controller\\\\ExceptionController\\:\\:throwRepositoryUnauthorizedAction\\(\\) has no return type specified\\.$#"
count: 1
Expand Down Expand Up @@ -90,96 +75,16 @@ parameters:
count: 1
path: src/bundle/Controller/UnauthenticatedRedirectController.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\DependencyInjection\\\\Compiler\\\\ElementFactoryCompilerPass\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/Compiler/ElementFactoryCompilerPass.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\DependencyInjection\\\\Compiler\\\\FieldTypeDataProviderPass\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/Compiler/FieldTypeDataProviderPass.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\DependencyInjection\\\\Compiler\\\\LimitationParserPass\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/Compiler/LimitationParserPass.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\DependencyInjection\\\\IbexaBehatExtension\\:\\:load\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaBehatExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\DependencyInjection\\\\IbexaBehatExtension\\:\\:prepend\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaBehatExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\DependencyInjection\\\\IbexaBehatExtension\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaBehatExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\DependencyInjection\\\\IbexaBehatExtension\\:\\:shouldLoadDxpServices\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaBehatExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Form\\\\RetryChoiceListFactory\\:\\:createListFromChoices\\(\\) has parameter \\$choices with no value type specified in iterable type iterable\\.$#"
count: 1
path: src/bundle/Form/RetryChoiceListFactory.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Form\\\\RetryChoiceListFactory\\:\\:createListFromChoices\\(\\) has parameter \\$value with no type specified\\.$#"
count: 1
path: src/bundle/Form/RetryChoiceListFactory.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Form\\\\RetryChoiceListFactory\\:\\:createListFromLoader\\(\\) has parameter \\$value with no type specified\\.$#"
count: 1
path: src/bundle/Form/RetryChoiceListFactory.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Form\\\\RetryChoiceListFactory\\:\\:createView\\(\\) has parameter \\$attr with no value type specified in iterable type array\\.$#"
count: 1
path: src/bundle/Form/RetryChoiceListFactory.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Form\\\\RetryChoiceListFactory\\:\\:createView\\(\\) has parameter \\$groupBy with no type specified\\.$#"
count: 1
path: src/bundle/Form/RetryChoiceListFactory.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Form\\\\RetryChoiceListFactory\\:\\:createView\\(\\) has parameter \\$index with no type specified\\.$#"
count: 1
path: src/bundle/Form/RetryChoiceListFactory.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Form\\\\RetryChoiceListFactory\\:\\:createView\\(\\) has parameter \\$preferredChoices with no value type specified in iterable type array\\.$#"
count: 1
path: src/bundle/Form/RetryChoiceListFactory.php

-
message: "#^Method Symfony\\\\Component\\\\Form\\\\ChoiceList\\\\Factory\\\\ChoiceListFactoryInterface\\:\\:createListFromChoices\\(\\) invoked with 3 parameters, 1\\-2 required\\.$#"
count: 1
path: src/bundle/Form/RetryChoiceListFactory.php

-
message: "#^Method Symfony\\\\Component\\\\Form\\\\ChoiceList\\\\Factory\\\\ChoiceListFactoryInterface\\:\\:createListFromLoader\\(\\) invoked with 3 parameters, 1\\-2 required\\.$#"
count: 1
path: src/bundle/Form/RetryChoiceListFactory.php

-
message: "#^Method Symfony\\\\Component\\\\Form\\\\ChoiceList\\\\Factory\\\\ChoiceListFactoryInterface\\:\\:createView\\(\\) invoked with 7 parameters, 1\\-6 required\\.$#"
count: 1
path: src/bundle/Form/RetryChoiceListFactory.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\IbexaBehatBundle\\:\\:build\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/IbexaBehatBundle.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\IbexaExtension\\:\\:configure\\(\\) has no return type specified\\.$#"
count: 1
Expand All @@ -200,11 +105,6 @@ parameters:
count: 1
path: src/bundle/IbexaExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\IbexaExtension\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/IbexaExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\IbexaExtension\\:\\:setMinkParameters\\(\\) has parameter \\$config with no value type specified in iterable type array\\.$#"
count: 1
Expand Down Expand Up @@ -2245,111 +2145,16 @@ parameters:
count: 1
path: src/lib/Core/Context/TimeContext.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Command\\\\GoBackCommand\\:\\:configure\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Core/Debug/Command/GoBackCommand.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Command\\\\RefreshPageCommand\\:\\:configure\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Core/Debug/Command/RefreshPageCommand.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Command\\\\ShowHTMLCommand\\:\\:configure\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Core/Debug/Command/ShowHTMLCommand.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Command\\\\ShowURLCommand\\:\\:configure\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Core/Debug/Command/ShowURLCommand.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Command\\\\TakeScreenshotCommand\\:\\:configure\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Core/Debug/Command/TakeScreenshotCommand.php

-
message: "#^Cannot call method getName\\(\\) on ReflectionType\\|null\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ObjectFunctionCallChainMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Matcher\\\\ObjectFunctionCallChainMatcher\\:\\:getFunctionName\\(\\) has parameter \\$tokenGroup with no type specified\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ObjectFunctionCallChainMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Matcher\\\\ObjectFunctionCallChainMatcher\\:\\:getMatches\\(\\) has parameter \\$info with no value type specified in iterable type array\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ObjectFunctionCallChainMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Matcher\\\\ObjectFunctionCallChainMatcher\\:\\:getMatches\\(\\) has parameter \\$tokens with no value type specified in iterable type array\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ObjectFunctionCallChainMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Matcher\\\\ObjectFunctionCallChainMatcher\\:\\:getMatches\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ObjectFunctionCallChainMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Matcher\\\\ObjectFunctionCallChainMatcher\\:\\:getObjectClass\\(\\) has parameter \\$tokenGroup with no type specified\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ObjectFunctionCallChainMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Matcher\\\\ObjectFunctionCallChainMatcher\\:\\:getObjectClass\\(\\) should return string but returns class\\-string\\|false\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ObjectFunctionCallChainMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Matcher\\\\ObjectFunctionCallChainMatcher\\:\\:getTokenName\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ObjectFunctionCallChainMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Matcher\\\\ObjectFunctionCallChainMatcher\\:\\:getTokenName\\(\\) has parameter \\$token with no type specified\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ObjectFunctionCallChainMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Matcher\\\\ObjectFunctionCallChainMatcher\\:\\:isFunctionCall\\(\\) has parameter \\$tokenGroup with no type specified\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ObjectFunctionCallChainMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Matcher\\\\ObjectFunctionCallChainMatcher\\:\\:isObjectCall\\(\\) has parameter \\$tokenGroup with no type specified\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ObjectFunctionCallChainMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Matcher\\\\ThisObjectMethodsMatcher\\:\\:getMatches\\(\\) has parameter \\$info with no value type specified in iterable type array\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ThisObjectMethodsMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Matcher\\\\ThisObjectMethodsMatcher\\:\\:getMatches\\(\\) has parameter \\$tokens with no value type specified in iterable type array\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ThisObjectMethodsMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Matcher\\\\ThisObjectMethodsMatcher\\:\\:getMatches\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: src/lib/Core/Debug/Matcher/ThisObjectMethodsMatcher.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Shell\\\\Shell\\:\\:displayExceptionMessage\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Core/Debug/Shell/Shell.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Debug\\\\Shell\\\\Shell\\:\\:getDefaultMatchers\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: src/lib/Core/Debug/Shell/Shell.php

-
message: "#^Method Ibexa\\\\Behat\\\\Core\\\\Log\\\\Failure\\\\AnalysisResult\\:\\:getJiraReference\\(\\) should return string but returns string\\|null\\.$#"
count: 1
Expand Down Expand Up @@ -2735,21 +2540,6 @@ parameters:
count: 1
path: tests/Browser/Locator/Validator/CssLocatorValidatorTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Bundle\\\\Behat\\\\Form\\\\Stub\\\\UnstableChoiceListFactory\\:\\:createListFromChoices\\(\\) has parameter \\$choices with no value type specified in iterable type iterable\\.$#"
count: 1
path: tests/bundle/Form/Stub/UnstableChoiceListFactory.php

-
message: "#^Method Ibexa\\\\Tests\\\\Bundle\\\\Behat\\\\Form\\\\Stub\\\\UnstableChoiceListFactory\\:\\:createView\\(\\) has parameter \\$attr with no value type specified in iterable type array\\.$#"
count: 1
path: tests/bundle/Form/Stub/UnstableChoiceListFactory.php

-
message: "#^Method Ibexa\\\\Tests\\\\Bundle\\\\Behat\\\\Form\\\\Stub\\\\UnstableChoiceListFactory\\:\\:createView\\(\\) has parameter \\$preferredChoices with no value type specified in iterable type array\\.$#"
count: 1
path: tests/bundle/Form/Stub/UnstableChoiceListFactory.php

-
message: "#^Method Ibexa\\\\Tests\\\\Behat\\\\Browser\\\\Element\\\\BaseTestCase\\:\\:createCollection\\(\\) has parameter \\$elementTexts with no type specified\\.$#"
count: 1
Expand Down
Loading
Loading