IBX-8708: Updated doc section in ibexa/behat repository #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbaragr
requested review from
micszo,
katarzynazawada,
tomaszszopinski,
bogusez,
juskora and
KamilSznajdrowicz
doc/running_tests.md
Outdated
|
|
||
| Another way is to use the Selenium Server Docker container and setting it up manually. Look at [ezplatform's .env file](https://github.com/ezsystems/ezplatform/blob/master/.env#L17) for the currently used version. | ||
| Another way is to use the Selenium Server Docker container and setting it up manually. Look at [manifest.json file](https://github.com/ibexa/recipes-dev/blob/master/ibexa/docker/4.6/manifest.json#L23) for the currently used version. | ||
|
|
||
| It can be set up using: | ||
| `docker run -p 4444:4444 -p 5900:5900 --shm-size=1gb -d --name=containerName selenium/standalone-chrome-debug:3.141.59` |
There was a problem hiding this comment.
This selenium image is 4 years old, maybe lets add here link for https://github.com/SeleniumHQ/docker-selenium 🤔
doc/extending.md
Outdated
| @@ -2,20 +2,20 @@ | |||
|
|
|||
| There are two extension points: | |||
| - ## Support for custom Field Types | |||
| If you want BehatBundle to support your custom Field Type when generating Content items you need to implement `EzSystems\Behat\API\ContentData\FieldTypeData\FieldTypeDataProviderInterface` and tag the service with the `ezplatform.behat.fieldtype_data_provider` tag. | |||
| If you want BehatBundle to support your custom Field Type when generating Content items you need to implement `Ibexa\Behat\API\ContentData\FieldTypeData\FieldTypeDataProviderInterface` and tag the service with the `ibexa.behat.fieldtype_data_provider` tag. | |||
There was a problem hiding this comment.
BehatBundle is now just behat repository, so it should be adjust in all places in this doc.
doc/features.md
Outdated
There was a problem hiding this comment.
In https://github.com/ibexa/behat/blob/4.6/doc/features.md?plain=1#L13 admin tag is obsolete (see please https://issues.ibexa.co/browse/IBX-3658), it is not needed here.
added 2 commits
September 19, 2024 13:04
|
tomaszszopinski
approved these changes
Sep 19, 2024
katarzynazawada
approved these changes
Sep 23, 2024
bogusez
approved these changes
Sep 23, 2024
adamwojs
approved these changes
Sep 28, 2024
adamwojs
deleted the
ibx-8708-update-doc-section-in-behat-repository
branch
|
You can merge it up @barbaragr |
Done 🎉 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: