Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8418: Added drafts deletion warning to trash modal #1321

Open
wants to merge 16 commits into
base: 4.6
Choose a base branch
from
Open

IBX-8418: Added drafts deletion warning to trash modal #1321

wants to merge 16 commits into from

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Aug 8, 2024 •
edited
Loading

🎫 Issue IBX-8418

Related PRs:

ibexa/core#398

Description:

image

@barw4 barw4 self-assigned this Aug 8, 2024
@barw4 barw4 mentioned this pull request Aug 8, 2024
Closed
@barw4 barw4 requested review from a team August 8, 2024 16:29
@barw4 barw4 force-pushed the ibx-8418-drafts-deletion-warning-trash-modal branch from 18e70f5 to 4dc6d6d Compare August 9, 2024 15:01
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mikadamczyk mikadamczyk requested a review from a team August 12, 2024 06:56
@konradoboza konradoboza requested a review from a team August 12, 2024 07:01
dew326
dew326 requested changes Aug 12, 2024
View reviewed changes
src/bundle/Resources/views/themes/admin/content/modal/location_trash.html.twig Outdated
@@ -15,6 +15,11 @@
{% endblock %}
{% block body_content %}
{{ 'trash.modal.send_to_trash.message'|trans|desc('Are you sure you want to send this Content item to Trash?') }}
<div class="ibexa-modal__trash-option">
<p class="ibexa-modal__option-label ibexa-label form-label required">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label with "*" as an explanation is probably not the best UX.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dew326 Don't we have the same for Conflicts with relations and Sub-items warnings?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this styling. The explanation is bigger and not gray.

Copy link
Contributor Author

@barw4 barw4 Aug 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, should I go with a simple paragraph then? Or any other example in which any particular html elements/classes should be used?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a new "trash_option" for example: "Drafts" and there put this explanation.
This is probably for @NataliaBecla and @juskora.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NataliaBecla, can we get your feedback on this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barw4 It seems there was a misunderstanding, as I thought we had resolved everything during the meeting. I suggest we go with @dew326 suggestion to use "Draft" as the title and format the sentence "sending this content item..." in regular font as shown below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, will do, thank you

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @barw4 👌👍 Looks good

@julitafalcondusza
Copy link

Hi! After discussing with @mnocon and @juskora - this will be the part of bigger project that will include improvement of messages within our platform. For now, all the texts need to stay as they are.

@barw4 barw4 requested a review from dew326 September 12, 2024 09:02
@barw4 barw4 force-pushed the ibx-8418-drafts-deletion-warning-trash-modal branch from 835b349 to d21881b Compare October 2, 2024 13:02
konradoboza
konradoboza approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But don't we need to adjust corresponding Behat scenario here?

@konradoboza konradoboza requested a review from a team October 3, 2024 06:12
@micszo micszo added the Tests update QA label indicating tests need to be updated label Oct 3, 2024
@barw4 barw4 mentioned this pull request Oct 17, 2024
Merged
@barw4 barw4 requested review from dew326 and a team October 24, 2024 15:35
@barw4
Copy link
Contributor Author

barw4 commented Oct 24, 2024

@ibexa/javascript-dev I had to change scss so re-review would be welcome d8d90a3

@barw4 barw4 requested a review from dew326 October 25, 2024 09:07
@katarzynazawada katarzynazawada mentioned this pull request Nov 6, 2024
Draft
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@dew326 dew326 dew326 approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@NataliaBecla NataliaBecla Awaiting requested review from NataliaBecla

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

@barw4 barw4

Labels
Improvement QA approved Tests update QA label indicating tests need to be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.