Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4675: Improved autogenerate field definition name #1117

Open
wants to merge 1 commit into
base: 4.6
Choose a base branch
from
Open

IBX-4675: Improved autogenerate field definition name #1117

wants to merge 1 commit into from

Conversation

adamwojs
Copy link
Member

Question Answer
JIRA issue IBX-4675
Type bug
Target version v4.6
BC breaks no
Doc needed no

Change pattern of autogenerated field definition name from "New field type (%type%)" to "New %name% (%type%)" e.g. "New text line (ezstring)"

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 14, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamwojs adamwojs requested a review from a team January 27, 2024 10:36
@Steveb-p Steveb-p requested a review from a team January 27, 2024 21:45
@ciastektk ciastektk requested a review from a team January 29, 2024 06:59
@mikadamczyk
Copy link
Contributor

@adamwojs browser tests are failing here, is it relevant?

@adamwojs adamwojs changed the base branch from main to 4.6 July 9, 2024 08:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamwojs adamwojs added the Tests update QA label indicating tests need to be updated label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@dew326 dew326 dew326 approved these changes

@ciastektk ciastektk ciastektk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
Ready for QA Tests update QA label indicating tests need to be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@adamwojs @mikadamczyk @Steveb-p @ciastektk @dew326 @konradoboza @Nattfarinn @ViniTou