review fixes pt 3

ibexa · Nov 6, 2024 · 94565f7 · 94565f7
1 parent 9914801
commit 94565f7
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/bundle/Resources/public/js/scripts/autogenerate.identifier.js b/src/bundle/Resources/public/js/scripts/autogenerate.identifier.js
@@ -1,14 +1,14 @@
 (function (doc, ibexa) {
     const sourceInputs = doc.querySelectorAll('[data-autogenerate-identifier-target-selector]');
 
-    const initAutogenerator = (elements, shouldAutogenerateValue = false) => {
+    const initAutogenerator = (elements, shouldAutogenerateValue) => {
         elements.forEach((sourceInput) => {
             const { autogenerateIdentifierTargetSelector } = sourceInput.dataset;
             const targetInput = doc.querySelector(autogenerateIdentifierTargetSelector);
             const identifierAutogenerator = new ibexa.core.SlugValueInputAutogenerator({
                 sourceInput,
                 targetInput,
-                shouldAutogenerateValue,
+                shouldAutogenerateValue: shouldAutogenerateValue || !targetInput.value,
             });
 
             identifierAutogenerator.init();
@@ -20,9 +20,9 @@
             'ibexa-autogenerate-identifier:init',
             (event) => {
                 const { fieldNode, shouldAutogenerateValue } = event.detail;
-                const sourceInputs = fieldNode.querySelectorAll('[data-autogenerate-identifier-target-selector]');
+                const sourceFields = fieldNode.querySelectorAll('[data-autogenerate-identifier-target-selector]');
 
-                initAutogenerator(sourceInputs, shouldAutogenerateValue);
+                initAutogenerator(sourceFields, shouldAutogenerateValue);
             },
             false,
         );