Image regression tests #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rm
force-pushed
the
image-regression-tests
branch
from
40c8530 to
662540b
Compare
w0rm
force-pushed
the
image-regression-tests
branch
from
b76ec1f to
5004cca
Compare
w0rm
force-pushed
the
image-regression-tests
branch
from
b20cad7 to
1db868a
Compare
w0rm
force-pushed
the
image-regression-tests
branch
from
fcbd21a to
4f90b7f
Compare
w0rm
force-pushed
the
image-regression-tests
branch
from
5108da0 to
85a7238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds image regression tests using Playwright. Unfortunately not all browsers were reliable. Chrome was rendering some black areas in white. Webkit didn't work in some cases - was rendering white. At first Firefox didn't work at all — WebGL is not available in the headless mode.
But then I tried to run it with a fake display using coactions/setup-xvfb and it only failed on two images. Apparently these were renderings of points with multisampling. I increased the tolerance for these two images, and all the tests passed!
The failed cases upload reports, that can be downloaded and examined. E.g. I changed the colours and made the tests fail:
I couldn't make playwright work in nix, so I installed it with npm instead. Locally, the nix devshell provides nodejs, that could be used to install playwright and its browsers.
In order to speedup the tests, I added sharding and a cache for playwright.