Allow concessions to be assigned during the faction phase #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using `List` for type hints rather than `list`, because apparently it's better.
Move the `generate_assign_concessions_action` function to the concession helper script because it's no longer going to be exclusive to the revolution phase.
Fix UI issue causing some concession term links to be broken.
Make the changes that allow concessions to be assigned during the faction phase. Also update the tests so that they cover this scenario.
Fix a UI issue where an anchor was nested inside another anchor. This was fixed by making the outer anchor into a div, but it still behaves like an anchor.
Remove arrows between Faction flags in the actions area because it's easier to not have them. Might add them back at some point.
iamlogand
force-pushed
the
feature/faction-phase-concessions
branch
from
77fd3c4 to
1b4deaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #512