Fix the senator portrait image load issue #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to improve senator portrait image load time by setting the images to `priority`.
iamlogand
added
the
cosmetic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make senator images load quick, which closes #385. The solution was to reduce the size of the images and disable Next.js image optimization for them. Disabling image optimization has counterintuitively made the initial load times much quicker. Now, when the image first loads, it's cached and used again whenever that same image is needed, regardless of size. This means that when a senator is selected, the large image will always appear instantly because it's already been downloaded.
Next.js image optimization is bad for this use case (or I might be misusing it). However, the Next.js
Imagecomponent is still marginally better than the standardimagetag because of theplaceholderprop, which is useful for users with particularly slow connections (e.g. slow 3G).