Add the Prior Consul title #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the backend generate a Prior Consul title for the Temporary Rome Consul during game setup, and ensure that it works by adding test coverage.
Swap the Font Awesome time icon for a home made one. Like the old one, the new icon also shows an hourglass.
Add prior consul to the frontend, including an icon and detail section content for the title.
Add the `TitleList` component for generalizing the logic associated with listing a senator's titles. Use this component in the senator detail content and the senator list to show information in the empty space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #333 by adding the Prior Consul title to the game. This title is currently assigned to the Temporary Rome Consul during game setup.
The title is described by a Prior Consul detail section:
This PR also closes #285 by introducing the
TitleListcomponent and using it in the senator list to fill in the empty space with useful information (as well as the senator detail content):