Senator history tab #267
Merged
Senator history tab #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare notification data for use as a basis for creating senator-notification relations.
Add a senator-notification relation model for tracking relationships between senators and notifications. Fix a bug where the mortality resolution rank assignment was failing. Also fix a bug in mortality notification appearance.
Rename `Notification` to `ActionLog` in the backend, because it will be used for logging as well as for notifications. The thing called a "notification" in the frontend has not been renamed because it's still being used only for notifications, for now.
Update the action log view so action logs can be filtered by senator, using the senator-action log relation. Fix migration script 0034 by stopping it from deleting all `SenatorActionLog` data. Update existing model `__str__` functions to include instance ID, making the admin site easier to use.
Set maximum widths for the detail and progress sections.
Rename the `Notification` class in the frontend to `ActionLog`, but leave variables and state that use it as-is, because those still use the `ActionLog` items as notifications.
Make the changes that enable the frontend to build a list of action logs, separate from the notification list, for showing action logs for each senator in the history tab. At this stage the listed actions don't look very informative. Action logs for a given senator are fetched whenever the user opens the senator detail section for that senator. They are not fetched again until the game is fully reloaded, but new log items are passed by WebSocket messages just as new notifications come in.
Fix a game setup bug where the senators and factions were not getting ranked during the initial game setup.
Add a notification at the start of the game to declare the Temporary Rome Consul. Also simplify the existing notification components.
Make the history tab look better. The tab now contains notification components, exactly like those in the notification section. However, these components have now been renamed to include the name "ActionLog" to reflect their dual/general purpose.
Fix an issue where duplicate action logs were appearing in the history tab.
Added past tense versions of all action log messages, for the senator history tab.
Add a placeholder for senators with no related action logs (i.e. no "history").
Set the icon for the Temporary Rome Consul action log to the Rome Consul icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The senator detail section now has two tabs: Attributes and History. Attributes contains the information that was already present on the senator detail, and History contains a list of action logs (new generalized name for what were called "notifications") related to the selected senator. Senator log items in the UI are like notifications, except they contain fewer details and use past tense (notifications use present or present perfect tense).
An action log variant was also added for the Temporary Rome Consul: