Sort the faction detail summary senators (#378)

Sort the faction detail summary senators using the same order as the senator list - alphabetic order on the name field. Generation doesn't matter here because the faction detail summary doesn't show dead senators.
iamlogand · Jan 18, 2024 · ba4c924 · ba4c924
1 parent 54a2c64
commit ba4c924
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/frontend/components/detailSections/DetailSection_Faction.tsx b/frontend/components/detailSections/DetailSection_Faction.tsx
@@ -37,9 +37,10 @@ const FactionDetails = () => {
   let senators: Collection<Senator> = new Collection<Senator>([])
   if (selectedDetail && selectedDetail.type == "Faction") {
     senators = new Collection<Senator>(
-      allSenators.asArray.filter(
-        (s) => s.faction === selectedDetail.id && s.alive === true
-      )
+      // Filter by faction and alive, then sort by name
+      allSenators.asArray
+        .filter((s) => s.faction === selectedDetail.id && s.alive === true)
+        .sort((a, b) => a.name.localeCompare(b.name))
     )
   }
   const faction: Faction | null = selectedDetail?.id