Fix some small UI defects

iamlogand · Oct 2, 2023 · 5b23361 · 5b23361
1 parent c9c5ffc
commit 5b23361
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/frontend/components/FactionListItem.module.css b/frontend/components/FactionListItem.module.css
@@ -40,7 +40,7 @@
 .symbols {
   display: flex;
   align-items: center;
-  justify-content: end;
+  justify-content: flex-end;
   gap: 2px;
 }
 

diff --git a/frontend/components/detailSections/DetailSection_Senator.tsx b/frontend/components/detailSections/DetailSection_Senator.tsx
@@ -64,8 +64,6 @@ const SenatorDetails = (props: SenatorDetailsProps) => {
 
   const scrollableAreaRef = useRef<HTMLDivElement | null>(null)
 
-  const [fetchingLogs, setFetchingLogs] = useState(false)
-
   // Get senator-specific data
   const senator: Senator | null = selectedEntity?.id ? allSenators.byId[selectedEntity.id] ?? null : null
   const faction: Faction | null = senator?.faction ? allFactions.byId[senator.faction] ?? null : null
@@ -112,7 +110,6 @@ const SenatorDetails = (props: SenatorDetailsProps) => {
     if (!senator) return
 
     await Promise.all([fetchActionLogs(), fetchSenatorActionLogs()])
-    setFetchingLogs(false)
 
     senator.logsFetched = true
     setAllSenators((senators: Collection<Senator>) => new Collection<Senator>(senators.asArray.map(s => s.id === senator.id ? senator : s)))
@@ -122,8 +119,6 @@ const SenatorDetails = (props: SenatorDetailsProps) => {
   useEffect(() => {
     if (!senator || senator?.logsFetched) return
 
-    setFetchingLogs(true)
-
     // Fetch action logs and senator action logs
     fetchLogs()
   }, [senator, fetchLogs])
@@ -133,7 +128,7 @@ const SenatorDetails = (props: SenatorDetailsProps) => {
     if (scrollableAreaRef.current) {
       scrollableAreaRef.current.scrollTop = scrollableAreaRef.current.scrollHeight
     }
-  }, [senatorDetailTab])
+  }, [senatorDetailTab, senator, senatorActionLogs])
 
   // Change selected tab
   const handleTabChange = (event: React.SyntheticEvent, newValue: number) => {

diff --git a/frontend/components/modals/ModalTitle.module.css b/frontend/components/modals/ModalTitle.module.css
@@ -7,7 +7,7 @@
 }
 
 .modalTitle button {
-  align-self: end;
+  align-self: flex-end;
   width: 30px;
   height: 30px;
   border: none;