Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codesandbox.io subdomain url #365

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agentofuser
Copy link

@CompuIves would it be possible to support this url scheme, please? At the moment I get a 400 error back. Thank you!

@iamcal
Copy link
Owner

iamcal commented Jun 11, 2019

this should be fine. where are you seeing a 400 error?

@CompuIves
Copy link
Contributor

Hmm, interesting. I think when you refer to a subdomain (new.codesandbox.io for example) you expect the "real" full-screen application. If we'd add it here then it would render the editor as embed. Or do you expect the full application @agentofuser ?

@agentofuser
Copy link
Author

Yeah, I was thinking of a preview embed (no editor) like the one on the user's profile showcase, with a link to open the editor view like the play (▶️) button on the showcase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants