Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micro adjustments #228

Merged
merged 3 commits into from
Aug 11, 2023
Merged

micro adjustments #228

merged 3 commits into from
Aug 11, 2023

Conversation

iambumblehead
Copy link
Owner

No description provided.

@iambumblehead
Copy link
Owner Author

iambumblehead commented Aug 10, 2023

the win32 + node 20.5 test ci is failing,

> test:node18-test-node
> cd tests-node && npm test


> test
> node --loader=esmock --test && npm run test:metaresolve

TAP version 13

# Subtest: should import mock objects, local
not ok 1 - should import mock objects, local
  ---
  duration_ms: 44.8231
  failureType: 'testCodeFailure'
  error: |-
    Expected values to be strictly equal:
    + actual - expected
    
    + 1691683602645
    - 123456789012
  code: 'ERR_ASSERTION'
  name: 'AssertionError'
  expected: 123456789012
  actual: 1691683602645
  operator: 'strictEqual'
  stack: |-
    TestContext.<anonymous> (file:///D:/a/esmock/esmock/tests/tests-node/esmock.node.global.test.js:15:10)
    async Test.run (node:internal/test_runner/test:581:9)
    async startSubtest (node:internal/test_runner/harness:204:3)

# Subtest: should mock files with hashbangs
not ok 4 - should mock files with hashbangs
  ---
  duration_ms: 26.3243
  failureType: 'testCodeFailure'
  error: |-
    Expected values to be strictly deep-equal:
    + actual - expected
    
    + []
    - [
    -   'foo'
    - ]
  code: 'ERR_ASSERTION'
  name: 'AssertionError'
  expected:
    0: 'foo'
  actual:
  operator: 'deepStrictEqual'
  stack: |-
    TestContext.<anonymous> (file:///D:/a/esmock/esmock/tests/tests-node/esmock.node.global.test.js:64:10)
    async Test.run (node:internal/test_runner/test:581:9)
    async Test.processPendingSubtests (node:internal/test_runner/test:325:7)

@iambumblehead
Copy link
Owner Author

and now the tests pass :/

@iambumblehead iambumblehead merged commit f824111 into master Aug 11, 2023
8 checks passed
@iambumblehead iambumblehead deleted the fewer-loc-fileurl branch August 11, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants