Skip to content

Commit

Permalink
Do not use underscore in image names
Browse files Browse the repository at this point in the history
When suffixing image_version (mkosi.version) do not use an underscore
since that breaks systemd-machined/machinectl because undescore are
invalid in machine names.

This is related to commit 7eb4ea8

Closes: systemd#2367
  • Loading branch information
Tj committed Feb 10, 2024
1 parent 71de2fe commit 27d3213
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mkosi/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ def config_default_output(namespace: argparse.Namespace) -> str:
output = namespace.image_id or namespace.image or "image"

if namespace.image_version:
output += f"_{namespace.image_version}"
output += f"-{namespace.image_version}"

return output

Expand Down

0 comments on commit 27d3213

Please sign in to comment.