Skip to content

Commit

Permalink
Merge pull request #315 from iadvize/NO-TICKET-fix-jest-no-test-callback
Browse files Browse the repository at this point in the history
NO-TICKET: fix eslint-config-jest old jest/no-test-callback rule
  • Loading branch information
guillaumewuip authored Oct 15, 2020
2 parents d0ff146 + 36cb961 commit 9d38e16
Show file tree
Hide file tree
Showing 4 changed files with 43 additions and 26 deletions.
9 changes: 9 additions & 0 deletions packages/eslint-config-jest/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changes

- Add new rules
- Allow eslint@7

### Fixes

- Remove old `jest/no-test-callback` rule

## [1.1.0]

### Changed
Expand Down
10 changes: 9 additions & 1 deletion packages/eslint-config-jest/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,15 @@ module.exports = {
'jest/no-truthy-falsy': 'error',
'jest/prefer-to-contain': 'error',
'jest/prefer-called-with': 'error',
'jest/no-test-callback': 'error',
'jest/no-deprecated-functions': 'error',
'jest/no-interpolation-in-snapshots': 'error',
'jest/valid-title': 'error',
'jest/no-conditional-expect': 'error',
'jest/no-duplicate-hooks': 'error',
'jest/no-export': 'error',
'jest/no-mocks-import': 'error',
'jest/no-standalone-expect': 'error',
'jest/require-top-level-describe': 'error',
},
},
],
Expand Down
48 changes: 24 additions & 24 deletions packages/eslint-config-jest/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/eslint-config-jest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@iadvize-oss/eslint-config": "^1.2.1"
},
"peerDependencies": {
"eslint": "^6.8.0"
"eslint": "^6.8.0 || ^7.0.0"
},
"dependencies": {
"@rushstack/eslint-patch": "^1.0.5",
Expand Down

0 comments on commit 9d38e16

Please sign in to comment.