Support Dropwizard 4.0.x #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spags-lacework
commented
Jul 17, 2024
Comment on lines
-10
to
12
| import javax.activation.UnsupportedDataTypeException; | ||
| import javax.validation.constraints.NotNull; | ||
| import jakarta.activation.UnsupportedDataTypeException; | ||
| import jakarta.validation.constraints.NotNull; | ||
|
|
There was a problem hiding this comment.
Dropwizard 4 uses Jakarta EE 9 which changes the namespace.
spags-lacework
commented
Jul 17, 2024
| @@ -140,6 +141,12 @@ | |||
| <!-- for convergence --> | |||
| <dependencyManagement> | |||
| <dependencies> | |||
| <dependency> | |||
There was a problem hiding this comment.
Running locally I had to add junit to be able to run.
spags-lacework
commented
Jul 17, 2024
| @@ -37,7 +37,8 @@ | |||
| </modules> | |||
|
|
|||
| <properties> | |||
| <dropwizard.version>2.0.21</dropwizard.version> | |||
| <java.version>11</java.version> | |||
There was a problem hiding this comment.
Dropwizard 4 minimum version is java11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I'm not sure if this repo is often maintained but I was looking to upgrade to Dropwizard 4 and I found usage of this library that needed to be upgraded as well to support Dropwizard.
Most of the changes are pretty obvious, Dropwizard 4 upgrades jakarta and java versions. Additionally I had to add a junit dependency to run
mvn testand BaseReporterFactory was moved.