Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance update (August) #150

Merged
merged 18 commits into from
Aug 9, 2024
Merged

Maintenance update (August) #150

merged 18 commits into from
Aug 9, 2024

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Aug 9, 2024

This pull request includes several updates to the ha-sagemcom-fast project. The changes focus on upgrading dependencies, improving error handling, and enhancing the configuration and setup process. Below is a summary of the most important changes:

Dependency Upgrades:

  • Upgraded the Docker image in .devcontainer/devcontainer.json to use Python 3.12.
  • Updated various pre-commit hooks to their latest versions in .pre-commit-config.yaml.
  • Updated the sagemcom_api requirement to version 1.3.2 in custom_components/sagemcom_fast/manifest.json.

Configuration and Setup Enhancements:

  • Modified the postCreateCommand in .devcontainer/devcontainer.json to include additional package installations.
  • Improved the initial login process in README.md to clarify the potential delay due to encryption method retrieval.
  • Enhanced the async_setup_entry method in custom_components/sagemcom_fast/__init__.py for better error handling and initial setup. [1] [2]

Error Handling Improvements:

  • Added handling for LoginRetryErrorException and UnsupportedHostException in custom_components/sagemcom_fast/config_flow.py and custom_components/sagemcom_fast/coordinator.py. [1] [2]
  • Updated error messages and descriptions in custom_components/sagemcom_fast/strings.json and custom_components/sagemcom_fast/translations/en.json to reflect new error conditions. [1] [2]

Codebase Simplification:

  • Removed unnecessary logging imports and refactored the ConfigFlow class in custom_components/sagemcom_fast/config_flow.py. [1] [2]

These changes collectively enhance the robustness, maintainability, and user experience of the ha-sagemcom-fast integration.

@iMicknl iMicknl merged commit 456ed3d into main Aug 9, 2024
4 checks passed
@iMicknl iMicknl deleted the 06_maintenance branch August 9, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant