Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tof analysis #141

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Tof analysis #141

wants to merge 7 commits into from

Conversation

dudarboh
Copy link
Member

@dudarboh dudarboh commented Sep 30, 2024

BEGINRELEASENOTES

  • Adding time-of-flight particle identification analysis codes from Bohdan Dudar's PhD studies.

ENDRELEASENOTES

TODO

  • Run Marlin and ensure that it successfully runs.
  • Check if the Track length reconstruction in Tracking is the latest and greatest

@dudarboh dudarboh changed the title Tof analysis [WIP] Tof analysis Sep 30, 2024
@dudarboh
Copy link
Member Author

Sorry, I only noticed #140 ...
Do we want to keep the warnings for now?

@tmadlener
Copy link
Contributor

I can lift the commit with the "external warnings" into a separate PR. Thanks for taking care of it, I haven't gotten around to it yet.

@tmadlener
Copy link
Contributor

Warnings of #140 have been fixed in #142. A simple rebase here should do the rest.

@dudarboh dudarboh changed the title [WIP] Tof analysis Tof analysis Oct 1, 2024
@tmadlener
Copy link
Contributor

I think the analysis and plotting code would be better suited for ILDPerformance, where a TimeOfFlight subfolder already exists. Is it somewhat easy to split that off from here?

@dudarboh
Copy link
Member Author

dudarboh commented Oct 2, 2024

I liked the idea that one can find all the codes related to my study in one place given only one link.
But I see that it is a bit inconsistent with other parts of the software...

I can move the analysis folder with all Python scripts to the ILDPerformance with a note that they are meant to be used with a ROOT file produced from this processor in MarlinReco.
Do you have any opinion on how to organise the old code from ILDPerformance/TimeOfFlight? Should everything else be put into the old folder? Maybe you have better ideas for a better name. Or is it so obsolete that it can be safely removed?

./src/BohdanDrawing is meant to be used inside the Marlin processor for debugging, so I would say it is better to stay here as I do not think it is very useful separately... Creating a separate processor just for these functions only is unnecessary, imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants