modifications for v11 reco #142
Conversation
There was a problem hiding this comment.
I would introduce dedicated Tracking{Digi,Reco}_FCCeeMDI.py (or similarly named) and dispatch to them if a v11 or v09 is requested. Probably the two models even need different tracking configurations, so potentially we need two sets of new files to fully run tracking for all versions. In the dedicated sets we can then put the necessary changes for each model, without having to change the configuration for the other detector models.
The following files should be removed:
GaudiILD09Reco.pyILD09Reconstruction.pymaterial_plots_2D.pyplotstyle.pybbudsc_3evt_SIM_v02.slciobbudsc_3evt_SIM_v09.slcioParticleFlow/PandoraPFAStd.xmlMarlinILD09Reco.xmlMarlinILD09RecoParsed.xmlMarlinGaudiConversionLastStep.sh
StandardConfig/production/Calibration/Calibration_ILD_l5_o1_v09.xml
Outdated
Show resolved
Hide resolved
StandardConfig/production/Calibration/Calibration_ILD_l5_v11.xml
Outdated
Show resolved
Hide resolved
StandardConfig/production/Calibration/Calibration_ILD_l5_o1_v09.cfg
Outdated
Show resolved
Hide resolved
StandardConfig/production/Calibration/Calibration_ILD_l5_v11.cfg
Outdated
Show resolved
Hide resolved
StandardConfig/production/Calibration/Calibration_ILD_l5_o1_v09.cfg
Outdated
Show resolved
Hide resolved
StandardConfig/production/Calibration/Calibration_ILD_l5_v11.cfg
Outdated
Show resolved
Hide resolved
| parser.add_argument( | ||
| "--trackingOnly", | ||
| help="Only Tracking is performed; built for reco testing purposes", | ||
| action="store_true", | ||
| ) |
There was a problem hiding this comment.
Does this option work with a "normal" geometry? I.e. does the reconstruction then run without exiting early or crashing?
|
I have added some CI workflows in #145. Can you rebase on top of the current master branch to pick those changes up? You should then also be able to add jobs for this geometry quite easily here: ILDConfig/.github/workflows/key4hep.yml Line 64 in 90d4ab3 |
|
CI for |
…Reconstruction.py
except for consts in .cfg file, not yet taken from CLD; testing with v09 and v11 needed
store_true already sets false as default, see https://docs.python.org/3/library/argparse.html#action removed one argument as the same dest was already used
…on/Calibration_ILD_l5_o1_v09.cfg Co-authored-by: Thomas Madlener <[email protected]>
…on/Calibration_ILD_l5_v11.cfg Co-authored-by: Thomas Madlener <[email protected]>
default in runBeamCalRepo was even wrong
Co-authored-by: Thomas Madlener <[email protected]>
Co-authored-by: Thomas Madlener <[email protected]>
BEGINRELEASENOTES
ENDRELEASENOTES