Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from master #605

Merged
merged 13 commits into from
Jan 2, 2025
Merged

Merge from master #605

merged 13 commits into from
Jan 2, 2025

Conversation

ikostan
Copy link
Member

@ikostan ikostan commented Jan 2, 2025

No description provided.

Merge pull request #601 from iKostanOrg/master
 sourcery-ai bot 4 minutes ago
suggestion (performance): Convert string to lowercase once before the loop for better performance

string.lower() is being called for each iteration. Converting to lowercase once before the loop would be more efficient.
 sourcery-ai bot 42 minutes ago
suggestion (testing): Add more test cases for calculate function

It would be beneficial to include additional test cases, such as examples with larger numbers, floating-point numbers, and leading/trailing spaces in the input string, to ensure comprehensive coverage.
 sourcery-ai bot 45 minutes ago
issue: Incorrect link for "Keep Hydrated!"

The link for "Keep Hydrated!" points to the README.md file. It should point to the solution directory like the other entries, presumably to https://github.com/ikostan/codewars/tree/master/kyu_8/keep_hydrated.
 sourcery-ai bot 47 minutes ago
issue: Duplicate entry for "My head is at the wrong end!"

This kata appears to be listed twice, in entries 15 and 36. Please remove the duplicate entry.
Merge pull request #603 from iKostanOrg/master
@ikostan ikostan self-assigned this Jan 2, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 11620d11
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (11620d1) Report Missing Report Missing Report Missing
Head commit (095f05f) 2616 2370 90.60%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#605) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request #605 has too many files changed.

We can only review pull requests with up to 300 changed files, and this pull request has 13964.

@ikostan ikostan merged commit d18d4fe into kyu6 Jan 2, 2025
30 checks passed
ikostan added a commit that referenced this pull request Jan 2, 2025
Merge pull request #605 from iKostanOrg/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant