Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #601 from iKostanOrg/master #602

Merged
merged 7 commits into from
Dec 31, 2024
Merged

Merge pull request #601 from iKostanOrg/master #602

merged 7 commits into from
Dec 31, 2024

Conversation

ikostan
Copy link
Member

@ikostan ikostan commented Dec 31, 2024

Merge from master

Summary by Sourcery

New Features:

  • Add "Find the in-between point" kata solution.

Copy link
Contributor

sourcery-ai bot commented Dec 31, 2024

Reviewer's Guide by Sourcery

This pull request adds a new kata solution for "Find the in-between point" and updates the documentation.

Sequence diagram for Find the in-between point calculation

sequenceDiagram
    participant C as Caller
    participant M as middle_point
    participant D as distance_between_two_points

    C->>M: middle_point(coordinates)
    activate M
    M->>M: Extract points a, b, c
    M->>D: Calculate distance(a,b)
    activate D
    D-->>M: a_b distance
    deactivate D
    M->>D: Calculate distance(a,c)
    activate D
    D-->>M: a_c distance
    deactivate D
    M->>D: Calculate distance(b,c)
    activate D
    D-->>M: b_c distance
    deactivate D
    M->>M: Compare distances
    M-->>C: Return middle point (1, 2, or 3)
    deactivate M
Loading

Class diagram for Find the in-between point solution

classDiagram
    class middle_point{
        +middle_point(*args) int
        -distance_between_two_points(a: tuple, b: tuple) float
    }
    note for middle_point "Takes 3 sets of 3D coordinates
Returns which point is in-between"
Loading

File-Level Changes

Change Details Files
Added solution for "Find the in-between point" kata.
  • Implemented the middle_point function to determine the middle point among three 3D coordinates.
  • Created unit tests for the middle_point function using the unittest and parameterized libraries.
  • Added a README file explaining the kata and solution.
  • Added an __init__.py file to mark the directory as a package.
  • Updated the kyu_6/README.md file to include the new kata solution in the list of completed katas for Python 3.
kyu_6/find_the_in_between_point/solution.py
kyu_6/find_the_in_between_point/test_middle_point.py
kyu_6/find_the_in_between_point/README.md
kyu_6/find_the_in_between_point/__init__.py
kyu_6/README.md
Updated documentation.
  • Added documentation files for the new kata solution.
  • Updated the kyu_6.rst file to include the new kata solution in the documentation index.
docs/kyu_6/kyu_6.find_the_in_between_point.module.rst
docs/kyu_6/kyu_6.find_the_in_between_point.readme.rst
docs/kyu_6/kyu_6.find_the_in_between_point.rst
docs/kyu_6/kyu_6.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • We don't review packaging changes - Let us know if you'd like us to change this.
  • All of the files are larger than we can process. We're working on it!

Copy link

codeclimate bot commented Dec 31, 2024

Code Climate has analyzed commit 11620d1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.5% (0.0% change).

View more on Code Climate.

@ikostan ikostan added the documentation Improvements or additions to documentation label Dec 31, 2024
@ikostan
Copy link
Member Author

ikostan commented Dec 31, 2024

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ikostan - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

kyu_6/find_the_in_between_point/solution.py Outdated Show resolved Hide resolved
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@ikostan ikostan merged commit a159ea7 into master Dec 31, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codewars documentation Improvements or additions to documentation kyu_6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant