-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge pull request #601 from iKostanOrg/master #602
Conversation
Merge from master
Reviewer's Guide by SourceryThis pull request adds a new kata solution for "Find the in-between point" and updates the documentation. Sequence diagram for Find the in-between point calculationsequenceDiagram
participant C as Caller
participant M as middle_point
participant D as distance_between_two_points
C->>M: middle_point(coordinates)
activate M
M->>M: Extract points a, b, c
M->>D: Calculate distance(a,b)
activate D
D-->>M: a_b distance
deactivate D
M->>D: Calculate distance(a,c)
activate D
D-->>M: a_c distance
deactivate D
M->>D: Calculate distance(b,c)
activate D
D-->>M: b_c distance
deactivate D
M->>M: Compare distances
M-->>C: Return middle point (1, 2, or 3)
deactivate M
Class diagram for Find the in-between point solutionclassDiagram
class middle_point{
+middle_point(*args) int
-distance_between_two_points(a: tuple, b: tuple) float
}
note for middle_point "Takes 3 sets of 3D coordinates
Returns which point is in-between"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. Here's why:
- We don't review packaging changes - Let us know if you'd like us to change this.
- All of the files are larger than we can process. We're working on it!
Code Climate has analyzed commit 11620d1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.5% (0.0% change). View more on Code Climate. |
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ikostan - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Merge from master
Summary by Sourcery
New Features: