Add UT for VoucherTypeCreated event #22
Conversation
| @@ -191,9 +191,9 @@ export function handleVoucherTypeCreated(event: VoucherTypeCreated): void { | |||
| if (!voucherType) { | |||
| voucherType = new VoucherType(id); | |||
| voucherType.eligibleAssets = []; | |||
| voucherType.description = description; | |||
| voucherType.duration = duration; | |||
|
|
||
| test('Should create a new VoucherType entity when an event is emitted', () => { | ||
| // Prepare mock event data | ||
| let id = BigInt.fromI32(1); |
There was a problem hiding this comment.
Should we add logic in subgraph sources which checks that:
id == voucherEntities.count()
?
There was a problem hiding this comment.
That could be an idea
I'm looking on how to do it
But now I'm thinking on how does the subgraph index this ? if it goes from latest block to first block => type 2 is created before type 1 etc. So count won't work (?)
There was a problem hiding this comment.
imo it's chronological (from 0 or start block). From a random non official blog post
The Graph Node will identify the data sources, startBlock from which the data source starts indexing, the contract address, and the events or calls to match. Next, Graph Node will start from the oldest start block (0 if no data source has a startBlock set) and go block by block trying to match any data source specified
I didn't check the official doc though :)
There was a problem hiding this comment.
After some reflexion I have made this
If it's not good for you I can remove this
| let description = 'Test Voucher'; | ||
| let duration = BigInt.fromI32(30); | ||
| let eventType1 = createVoucherTypeCreatedEvent(id, description, duration); | ||
| handleVoucherTypeCreated(eventType1); | ||
|
|
||
| let descriptionType2 = 'Test Voucher number 2'; | ||
| let durationType2 = BigInt.fromI32(150); | ||
| let event = createVoucherTypeCreatedEvent(id, descriptionType2, durationType2); |
There was a problem hiding this comment.
Maybe harmonize: description1, duration1, event1 & description2, duration2, event2
tests/unit/utils/utils.ts
Outdated
| event.parameters.push(new ethereum.EventParam('id', ethereum.Value.fromUnsignedBigInt(id))); | ||
| event.parameters.push( | ||
| new ethereum.EventParam('description', ethereum.Value.fromString(description)), | ||
| ); | ||
| event.parameters.push( | ||
| new ethereum.EventParam('duration', ethereum.Value.fromUnsignedBigInt(duration)), | ||
| ); |
There was a problem hiding this comment.
I think it's time we define a function setEventParams() and use it everywhere to avoid repeating code.
There was a problem hiding this comment.
After looking deep into it => updated
| } | ||
|
|
||
| export class EventParamBuilder { | ||
| private params: EventParam[] = []; |
There was a problem hiding this comment.
Why not:
| private params: EventParam[] = []; | |
| private params: ethereum.EventParam[] = new Array<ethereum.EventParam>(); |
| build(event: ethereum.Event): void { | ||
| event.parameters = new Array<ethereum.EventParam>(); | ||
| for (let i = 0; i < this.params.length; i++) { | ||
| event.parameters.push( | ||
| new ethereum.EventParam(this.params[i].key, this.params[i].value), | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
| build(event: ethereum.Event): void { | |
| event.parameters = new Array<ethereum.EventParam>(); | |
| for (let i = 0; i < this.params.length; i++) { | |
| event.parameters.push( | |
| new ethereum.EventParam(this.params[i].key, this.params[i].value), | |
| ); | |
| } | |
| } | |
| build(): ethereum.EventParam[] { | |
| return this.params; | |
| } |
| EventParamBuilder.init() | ||
| .address('voucher', voucher) | ||
| .address('owner', owner) | ||
| .bigInt('voucherType', voucherType) | ||
| .bigInt('expiration', expiration) | ||
| .bigInt('value', value) | ||
| .build(event); |
There was a problem hiding this comment.
| EventParamBuilder.init() | |
| .address('voucher', voucher) | |
| .address('owner', owner) | |
| .bigInt('voucherType', voucherType) | |
| .bigInt('expiration', expiration) | |
| .bigInt('value', value) | |
| .build(event); | |
| event.parameters = EventParamBuilder.init() | |
| .address('voucher', voucher) | |
| .address('owner', owner) | |
| .bigInt('voucherType', voucherType) | |
| .bigInt('expiration', expiration) | |
| .bigInt('value', value) | |
| .build(); |
No description provided.