Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test suite #21

Merged
merged 20 commits into from
Oct 30, 2024
Merged

Add integration test suite #21

merged 20 commits into from
Oct 30, 2024

Conversation

jeremyjams
Copy link
Member

  • Logs:
14:58:11    Integration tests
14:58:11  Starting services..
[...]
15:04:44      ✔ should get protocol (253ms)
[...]
15:04:44    1 passing (7m)
  • Main & develop are now protected and both unit & integration test checks are mandatory:
    image

@jeremyjams jeremyjams self-assigned this Oct 29, 2024
zguesmi
zguesmi reviewed Oct 29, 2024
View reviewed changes
docker/Dockerfile Outdated Show resolved Hide resolved
docker/test/docker-compose.yml Outdated Show resolved Hide resolved
@jeremyjams jeremyjams requested a review from zguesmi October 30, 2024 10:04
zguesmi
zguesmi approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@zguesmi zguesmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

jeremyjams
jeremyjams commented Oct 30, 2024
View reviewed changes
.github/workflows/main.yml
@@ -20,3 +20,4 @@ jobs:
run: npm run test
- name: Test build
run: npm run build
# See Jenkinsfile-itest for "Run integration tests" step
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DamienMure FYI 1

Jenkinsfile-itest
}
}
docker.image('node:22-alpine')
.inside('-v /var/run/docker.sock:/var/run/docker.sock --network=host --user=root') {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DamienMure FYI 2

@jeremyjams jeremyjams merged commit 60f469d into develop Oct 30, 2024
2 checks passed
@jeremyjams jeremyjams deleted the feature/add-protocol-integration-test branch October 30, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfournieriExec gfournieriExec gfournieriExec approved these changes

@zguesmi zguesmi zguesmi approved these changes

@Le-Caignec Le-Caignec Awaiting requested review from Le-Caignec

Assignees

@jeremyjams jeremyjams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremyjams @zguesmi @gfournieriExec