Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 74 customer pricelist #78

Merged
merged 9 commits into from
Apr 20, 2021
Merged

Conversation

davidpodhola
Copy link
Contributor

@davidpodhola davidpodhola commented Apr 20, 2021

TL;DR

This is the first part about the Customer Price List adding the Customer Price List CRUD screens and the sales invoice line calculation. It is missing:

  • changes in the invoicing screen
  • setting up the products for the Customer Price List
  • reports

Proof

image

and also see sales.invoice.line.service.spec.ts.

Merge request checklist

Please check if your merge request fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been reviewed and added/updated if needed (for bug fixes/features)
  • Build (yarn build) was run locally and any changes were pushed for both API and clients
  • API (yarn api:dev) runs locally and any fixes were made for failures
  • Admin Client (cd clients/admin && yarn start) runs locally and any fixes were made for failures

Merge request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no APIoduce changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Before this merge request

You had to calculate the invoice line price manually.

How you fixed what was wrong

Changed the sales invoice line calculation to use the price list if available.

@davidpodhola davidpodhola marked this pull request as ready for review April 20, 2021 10:54
@davidpodhola davidpodhola merged commit f841893 into master Apr 20, 2021
@davidpodhola davidpodhola deleted the issue-74-Customer_pricelist branch April 20, 2021 13:35
@davidpodhola davidpodhola linked an issue Apr 21, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customer pricelist
1 participant