[php8] undeclared var is_test

[demeritcowboy]

No description provided.

[adixon]

I notice this property is also referenced in core!

https://github.com/civicrm/civicrm-core/blob/694c57d19e227ca8f326b6459736eb0f4dbe77fb/CRM/Core/Payment.php#L1300

[demeritcowboy]

I saw that but I don't see where it's ever set in core, or where that function gets called.

[adixon]

Yeah, I think your patch here is correct, and you also discovered a core bug along the way ... but I won't tell if you don't.

[demeritcowboy]

It was added at civicrm/civicrm-core@49c882a, but then the rest of that PR doesn't use it and instead uses getCancelUrl added in another part of that PR and which is an almost identical function. 🤷‍♂️
Omnipay has its own version of getReturnFailUrl but also doesn't seem to really use it. It assigns it to errorUrl but never uses that, and I don't see that in core either.

[adixon]

My best guess is that eileen was supporting an old way of identifying test submissions from legacy processors that used it.