Improve mapping between XDS XON and FHIR Organization #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qligier
force-pushed
the
165-wrong-xon-generated-when-the-fhir-organization-has-no-system
branch
from
56b9226
to
217b4d7
Compare
qligier
changed the title
|
@unixoid can you please review? |
unixoid
reviewed
Aug 19, 2024
| result.addIdentifier().setSystem(system).setValue(id); | ||
| } else { | ||
| final var identifier = result.addIdentifier().setValue(id); | ||
| if (id.startsWith("urn:oid:") || id.startsWith("urn:uuid:")) { |
There was a problem hiding this comment.
can it be simplified to if (id.startsWith("urn:")) ?
unixoid
reviewed
Aug 19, 2024
| @@ -141,4 +141,12 @@ public static Processor retrievedDocumentSetToHttResponse() { | |||
| }; | |||
| } | |||
| */ | |||
|
|
|||
| public static boolean isUnprefixedOid(final String oid) { | |||
| return oid != null && oid.matches("\\d+(\\.\\d+)+"); | |||
There was a problem hiding this comment.
here and in isUprefixedUuid: probably it would make sense to introduce static constants in order to avoid pattern recompilation on each call. For example,
private static final Pattern OID_PATTERN = Pattern.compile("\\d+(\\.\\d+)+");
public static boolean isUnprefixedOid(final String oid) {
return (oid != null) && OID_PATTERN.matcher(oid).matches();
}
unixoid
reviewed
Aug 19, 2024
| } | ||
| return result; | ||
| } | ||
| if (identifier.hasSystem()) { |
There was a problem hiding this comment.
proposal: change line 1011 to if ((identifier != null) && identifier.hasValue()) {, change line 1021 to simply } else {.
qligier
force-pushed
the
165-wrong-xon-generated-when-the-fhir-organization-has-no-system
branch
from
217b4d7
to
7aa87aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165