refactor: remove the traverse code in parseJSXElement to eliminate redundant calls for setting translation keys
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #250 +/- ##
==========================================
- Coverage 91.31% 91.13% -0.18%
==========================================
Files 6 6
Lines 564 553 -11
==========================================
- Hits 515 504 -11
Misses 49 49
☔ View full report in Codecov by Sentry. |
cheton
changed the title
parseJSXElement to eliminate redundant calls for setting translation keys
cheton
added a commit
that referenced
this pull request
Jul 11, 2023
…redundant calls for setting translation keys (#250)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the traverse code in
parseJSXElementto eliminate redundant calls for setting translation keys. The functionality is now handled by theacorn-jsxwalklibrary, which allows for traversing allJSXElementnodes seamlessly.Checklist
npm run test