Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

Sab rear rev2 parts #116

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Sab rear rev2 parts #116

wants to merge 8 commits into from

Conversation

Yjaafar1
Copy link
Contributor

SAB Rear ESP 32 Part

Checklist

  • Did you create any new schematics or boards?
    • Did you make a PR for them in circuits-2022? If so, please pause until you get this PR merged.
  • [ X] Did you pull main into your branch?
    • [X ] Did you check for merge conflicts?
    • [ X] Did you resolve any that occurred? If you are having trouble or are confused, contact a lead!
  • [X ] Did you fill out the above template?
  • Did you assign the right people for review (on the right)?
  • [ X] Did you comply with the library style guidelines?

@Yjaafar1 Yjaafar1 requested review from BZhu792 and zli909 March 27, 2022 18:18
BZhu792
BZhu792 previously approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@BZhu792 BZhu792 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the part is good enough to get merged, let's do it. Will wait until validation for the board

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BZhu792 BZhu792 BZhu792 left review comments

@zli909 zli909 Awaiting requested review from zli909

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yjaafar1 @BZhu792 @yjaafar3