OS-8046. Add the GCP service to the "Public S3 buckets" recommendation

hystax · Dec 5, 2024 · 3a33687 · 3a33687
1 parent c65660c
commit 3a33687
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/ngui/ui/src/containers/RecommendationsOverviewContainer/recommendations/PublicS3Buckets.tsx b/ngui/ui/src/containers/RecommendationsOverviewContainer/recommendations/PublicS3Buckets.tsx
@@ -1,9 +1,9 @@
 import { FormattedMessage } from "react-intl";
 import RecommendationListItemResourceLabel from "components/RecommendationListItemResourceLabel";
 import TextWithDataTestId from "components/TextWithDataTestId";
-import { AWS_S3, NEBIUS_SERVICE } from "hooks/useRecommendationServices";
+import { AWS_S3, GCP_CLOUD_STORAGE, NEBIUS_SERVICE } from "hooks/useRecommendationServices";
 import { detectedAt, poolOwner, resource, resourceLocation } from "utils/columns";
-import { AWS_CNR, NEBIUS } from "utils/constants";
+import { AWS_CNR, GCP_CNR, NEBIUS } from "utils/constants";
 import BaseRecommendation, { CATEGORY_SECURITY } from "./BaseRecommendation";
 
 const columns = [
@@ -58,9 +58,9 @@ class PublicS3Buckets extends BaseRecommendation {
 
   emptyMessageId = "noPublicS3Buckets";
 
-  services = [AWS_S3, NEBIUS_SERVICE];
+  services = [AWS_S3, NEBIUS_SERVICE, GCP_CLOUD_STORAGE];
 
-  appliedDataSources = [AWS_CNR, NEBIUS];
+  appliedDataSources = [AWS_CNR, NEBIUS, GCP_CNR];
 
   categories = [CATEGORY_SECURITY];
 

diff --git a/ngui/ui/src/hooks/useRecommendationServices.ts b/ngui/ui/src/hooks/useRecommendationServices.ts
@@ -21,6 +21,7 @@ export const AZURE_NETWORK = "azureNetwork";
 
 export const GCP_COMPUTE_ENGINE = "gcpComputeEngine";
 export const GCP_IAM = "gcpAim";
+export const GCP_CLOUD_STORAGE = "gcpCloudStorage";
 
 export const NEBIUS_SERVICE = "nebius";
 
@@ -93,6 +94,10 @@ const GCP_SERVICES = Object.freeze({
   [GCP_IAM]: {
     type: GCP_CNR,
     name: "services.iam"
+  },
+  [GCP_CLOUD_STORAGE]: {
+    type: GCP_CNR,
+    name: "services.cloudStorage"
   }
 });
 

diff --git a/ngui/ui/src/translations/en-US/app.json b/ngui/ui/src/translations/en-US/app.json
@@ -629,8 +629,6 @@
   "edit{}": "Edit {value}",
   "eitherMinOrMaxMustBeDefined": "Either minimimum or maximum must be defined",
   "email": "Email",
-  "emailVerificationDescription": "To verify your email, please enter the verification code sent to:",
-  "emailVerifiedSuccessfully": "Email has been verified successfully!",
   "emailNotifications": "Email notifications",
   "emailTemplates.accountManagement.invite.description": "Notification of an invitation to join OptScale",
   "emailTemplates.accountManagement.invite.title": "Invitation notification",
@@ -666,6 +664,8 @@
   "emailTemplates.systemNotifications.environment_changes.title": "Environment changed",
   "emailTemplates.systemNotifications.report_imports_passed_for_org.description": "Confirmation that initial expense processing for your organization is complete",
   "emailTemplates.systemNotifications.report_imports_passed_for_org.title": "Expenses initial processing completed",
+  "emailVerificationDescription": "To verify your email, please enter the verification code sent to:",
+  "emailVerifiedSuccessfully": "Email has been verified successfully!",
   "employee": "Employee",
   "enabled": "Enabled",
   "endDate": "End date",
@@ -1983,6 +1983,7 @@
   "serverError": "Server error",
   "service": "Service",
   "serviceAccountId": "Service account ID",
+  "services.cloudStorage": "Cloud Storage",
   "services.compute": "Compute",
   "services.computeEngine": "Compute Engine",
   "services.ebs": "EBS",