OS-7952. Fixed bug with none cloud_resource_id

hystax · Nov 20, 2024 · 36a68dd · 36a68dd
1 parent 44d1b69
commit 36a68dd
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/bumiworker/bumiworker/modules/recommendations/short_living_instances.py b/bumiworker/bumiworker/modules/recommendations/short_living_instances.py
@@ -188,7 +188,6 @@ def _get(self):
         result = []
         for sli_id in short_living_instances_map:
             resource_hash = None
-            resource_id = None
             resource_exp = short_living_instances_map.get(sli_id, {})
             flavor_cost = resource_exp.get('flavor_cost', 0)
             other_cost = resource_exp.get('other_cost', 0)
@@ -199,7 +198,6 @@ def _get(self):
                 _, resources = self.rest_client.cloud_resource_list(
                     cloud_account_id, cloud_resource_hash=sli_id)
             else:
-                resource_id = sli_id
                 _, resources = self.rest_client.cloud_resource_list(
                     cloud_account_id, cloud_resource_id=sli_id)
             resources = resources.get('resources', [])
@@ -212,7 +210,7 @@ def _get(self):
             saving = flavor_cost * SPOT_SAVING_COEFFICIENT
             if saving > 0:
                 result.append({
-                    'cloud_resource_id': resource_id,
+                    'cloud_resource_id': resource.get('cloud_resource_id'),
                     'cloud_resource_hash': resource_hash,
                     'resource_name': resource.get('name'),
                     'resource_id': resource.get('id'),