Fix CI build for Ubuntu 18.04 #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it is too much of a pain, maybe upgrade to something more recent than GCC 6 and add a note? Also: if checkout's node is too crappy to work on Ubuntu 18, might it make sense to checkout on our own? |
I was afraid that the Github actions required node.js also for some more magical things during the runner image orchestration, but it seems to work just like that |
Bouncner
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #245, we noticed that the Github checkout action now uses a Node.js version that is incompatible with our gcc-6/Ubuntu-18.04 stage. Thus, we pull the code manually for this stage.