Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please include cstdint for gcc13 #245

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Please include cstdint for gcc13 #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb5a4ed
include cstdint for gcc13 or later
toge Jun 26, 2024
80ecb15
use stdint.h instead of cstdint
toge Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sql/ColumnType.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#define SQLPARSER_COLUMN_TYPE_H

#include <ostream>
#include <stdint.h>

namespace hsql {
enum class DataType {
Expand Down
1 change: 1 addition & 0 deletions src/sql/Expr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#include "Expr.h"
#include <stdio.h>
#include <string.h>
#include <stdint.h>
Copy link
Member

@dey4ss dey4ss Jul 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pick here: Please have a look at the include order. Running the format.sh script should already fix this.

I also started a workflow run. Not sure what happened to the gcc-6 stage though. However, we already have a gcc-13 runner there since #242.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have a problem with Ubuntu 18. But where does node come from? It's from the GitHub action checkout? Curious how that can fail.

https://stackoverflow.com/a/74912791

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with #246
@toge to pass the CI, you need to merge the current master.

#include "SelectStatement.h"

namespace hsql {
Expand Down
1 change: 1 addition & 0 deletions src/sql/statements.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include "statements.h"
#include "AlterStatement.h"
#include <stdint.h>

namespace hsql {

Expand Down
1 change: 1 addition & 0 deletions src/util/sqlhelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <map>
#include <sstream>
#include <string>
#include <stdint.h>

namespace hsql {

Expand Down
Loading