-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Input Capture Desktop Portal #268
base: master
Are you sure you want to change the base?
Conversation
@@ -1,6 +1,7 @@ | |||
[submodule "hyprland-protocols"] | |||
path = subprojects/hyprland-protocols | |||
url = https://github.com/hyprwm/hyprland-protocols | |||
url = https://github.com/3l0w/hyprland-protocols | |||
branch = feat/input-capture-impl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
marking this one as a blocker until this is removed so we dont forget (don't resolve)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit of a lengthy review, mostly style and guidelines. Many comments apply to the entirety of the PR
tag me for review when ready |
91e9b70
to
fb0e34d
Compare
b9b17ef
to
37c5d83
Compare
hey, uh the new version did not compile with the following error:
|
37c5d83
to
75a754a
Compare
I am aware, it is due to the sdbus version bumb, it should be good now |
I am having this:
|
src/portals/InputCapture.hpp
Outdated
@@ -0,0 +1,100 @@ | |||
#pragma once | |||
#include "dbusDefines.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include "dbusDefines.hpp" | |
#include "../dbusDefines.hpp" |
I pushed the fix |
i gave feedback in hyprwm/Hyprland#7919 |
Deskflow:
Is this currently working? |
it works for me. restart ur xdg-desktop-portals after installation |
Also make sure that the hyprland.portal file has been copied over |
also, as an update, still consistently have my modifiers always held down on the client and have to restart input leap/the connection(stop then start again) to fix |
It seems to work fine now as the server. |
also @3l0w, input capture should not work in ext-session-lock. i.e. rn in hyprlock, you can still control other device via input leap |
dont know if this will work: https://github.com/waycrate/xdg-desktop-portal-luminous since hyprland is no longer wlroots. but it does have |
Describe your PR, what does it fix/add?
This PR implements the input capture desktop portal with the new protocol defined in hyprwm/hyprland-protocols#8.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Nothing to declare yet.
Is it ready for merging, or does it need work?
It work when used with hyprwm/Hyprland#7919, but still need work, like sending the keyboard layout, or security concerns.