Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some more box improvements and test cases #3

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Some more box improvements and test cases #3

merged 7 commits into from
Jun 24, 2024

Conversation

JassonCordones
Copy link
Contributor

@JassonCordones JassonCordones commented Jun 24, 2024 •
edited
Loading

  • Added comments to understand how box header works
  • Extended the EXPECT macro to evaluate Vector2D test cases
  • Added box.cpp test cases

Sorry, forgot to delete branch after merge.

vaxerski
vaxerski reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you slap a clang-format? the formatting looks off.

@JassonCordones
Copy link
Contributor Author

clang-format applied.

vaxerski
vaxerski approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit pedantic but sure, thanks!

@vaxerski vaxerski merged commit 7a2c2c9 into hyprwm:main Jun 24, 2024
4 checks passed
@JassonCordones JassonCordones deleted the box_improvements branch June 24, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JassonCordones @vaxerski