core: improve signal handling #539
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaideiaDilemma
commented
Oct 30, 2024
| @@ -1156,7 +1226,7 @@ zwlr_screencopy_manager_v1* CHyprlock::getScreencopy() { | |||
| } | |||
|
|
|||
| void CHyprlock::attemptRestoreOnDeath() { | |||
| if (m_bTerminate || m_sCurrentDesktop != "Hyprland") | |||
There was a problem hiding this comment.
Any Idea why we didn't try to restore when m_bTerminate is true before?
There was a problem hiding this comment.
Maybe we want to check if we are actually locked instead?
Cause if we aren't there is no point in trying to restore.
There was a problem hiding this comment.
uhhh cuz if it crashes after nlock
There was a problem hiding this comment.
yeah but terminate does not mean we already unlocked
|
|
Use signalfd to handle SIGUSR1, SIGUSR2 via poll in the event loop.
PaideiaDilemma
force-pushed
the
main
branch
2 times, most recently
from
1788316
to
1803834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to handle SIGUSR1 and SIGUSR2 via the main thread using
signalfd.I did that cause when we
forceUpdateTimers, we are currently not safe in multiple ways.We don't acquire the timers lock for
m_vTimers, which we can't do cause we are in a async signal context.We call other async signal unsafe functions.
So I tried moving
forceUpdateTimersto the main thread (#536), but that has the problem that we need to wake the main thread somehow and that would require async signal unsafe functions again.Considering hyprlock is event driven using signalfd made sense.
I hope that this fixes#535. Seems like it does not, but this still makes sense to change i think.Some testing wanted before merging.
Thanks!