-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hyprlock] Add more description for monitor field #746
base: main
Are you sure you want to change the base?
Conversation
Change-Id: I95986cdf8f5bbfd45a41642849c66d6aefb23dfe
@PaideiaDilemma is this correct? |
{{< callout >}} | ||
|
||
Pay attention! You do not need to add `desc:` prefix like in | ||
[`hyprland.conf`](../Configuring/Monitors.md) | ||
|
||
{{</ callout >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not true.
The current check is surf->output->stringDesc.starts_with(c.monitor)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we support prefixing with desc:
as well for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prolly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The desc:
variant stops work for me at all. The ripgrep did not find any occurrences of desc:
in sources. I found the line @PaideiaDilemma talking about in sources and tries to remove the desc:
from config. And it worked.
So I decided to update doc and mention this peculiarity.
I think, we should to add prefix for consistency too, but we should have clear actual documentation as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I create a MR in hyprlock to support desc:
.
Sorry I initially misunderstood the wording, because i read it too fast. You were of course correct on this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove the this section, but the rest is fine.
The
monitors
field of hyprlock was not described clearly. Trying to fix that.