Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak build with Clang #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unbreak build with Clang #25

wants to merge 1 commit into from

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented May 8, 2023

Only Gold and LLD support --no-gnu-unique. GCC defaults to -fuse-ld=bfd, so --no-gnu-unique is discarded unless GCC itself was built with --disable-gnu-unique-object. Clang doesn't have such magic, so --no-gnu-unique fails because it's not supported by the compiler unlike -Wl,--no-gnu-unique which is passed to the linker and works fine with -fuse-ld=gold, -fuse-ld=lld or when /usr/bin/ld is Gold/LLD.

Also, Meson support in hyprbars doesn't try to pass --no-gnu-unique

Only Gold and LLD implement --no-gnu-unique but Makefile is too
primitive to figure out which toolchain is used by default.
@jbeich jbeich mentioned this pull request May 8, 2023
@vaxerski
Copy link
Member

vaxerski commented May 9, 2023

the issue is that without no gnu unique reloading (unloading, then loading) a plugin does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants