Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyprbars: Change configuration key "col.text" to "bar_text_color" #236

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Hyprbars: Change configuration key "col.text" to "bar_text_color" #236

wants to merge 3 commits into from

Conversation

ia74
Copy link

@ia74 ia74 commented Oct 24, 2024

No description provided.

vaxerski
vaxerski reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what for

@ia74
Copy link
Author

ia74 commented Nov 4, 2024

less confusion
image

@fufexan
Copy link
Member

fufexan commented Nov 4, 2024

The hyprland col. keywords could use a change as well.

@vaxerski
Copy link
Member

vaxerski commented Nov 5, 2024

yes but then we pointlessly break the config

@fufexan
Copy link
Member

fufexan commented Nov 5, 2024

Any change for the better is worth a breakage. Plus we can just deprecate the old col. for a release or two.

@vaxerski
Copy link
Member

vaxerski commented Nov 5, 2024

this is very marginally better, I am not convinced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ia74 @fufexan @vaxerski