Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix changeWindowZOrder #8494

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix changeWindowZOrder #8494

merged 1 commit into from
Nov 18, 2024

Conversation

Aqa-Ib
Copy link
Contributor

@Aqa-Ib Aqa-Ib commented Nov 16, 2024

Describe your PR, what does it fix/add?

Fixes #8443

Is it ready for merging, or does it need work?

ready

@github-actions github-actions bot added the core label Nov 16, 2024
@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Nov 17, 2024

This was introduced in #6877
@UjinT34 do you have an insight ? Can we remove this or else?

@UjinT34
Copy link
Contributor

UjinT34 commented Nov 17, 2024

Without this commit 507df67 every click on a fullscreen floating window will result in unneeded reordering which will add damage to monitor and schedule an unwanted frame. Maybe it returns too early. g_pHyprRenderer->damageMonitor shouldn't be called when the clicked window is already on top and fullscreen.

@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Nov 17, 2024

OK, I found that it shouldn't return before executing pWindow->m_bCreatedOverFullscreen = true; because CInputManager::mouseMoveUnified needs that in order to work properly. So I just moved that operation before the early return.

@vaxerski
Copy link
Member

@UjinT34 is this version fine? (vrr stuff)

@UjinT34
Copy link
Contributor

UjinT34 commented Nov 18, 2024

It's fine

@vaxerski vaxerski merged commit 9749351 into hyprwm:main Nov 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mouse clicks registering behind topmost floating window
3 participants