hyprpm: install headers locally #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like how i just realized I hardcoded the path with my user name lol |
Closed
Closed
|
@jbeich would this change allow us to |
|
Ok, finally got to test this after wasting a bunch of time discovering makepkg clobbers branch names :/ All seems good to me. Normal and forced update both worked without header conflicts. When plugins don't load due to mismatch sometimes the notification gets hidden by the big red config syntax error banner, but that's not an issue with this PR; I'll (eventually) create another issue for that one. |
|
top. Merging then. Thanks bros |
fufexan
pushed a commit
to fufexan/Hyprland
that referenced
this pull request
Feb 23, 2024
* hyprpm: install headers locally * oopsie
https123456789
added a commit
to https123456789/Hyprland
that referenced
this pull request
Mar 10, 2024
https123456789
added a commit
to https123456789/Hyprland
that referenced
this pull request
Apr 10, 2024
vaxerski
pushed a commit
that referenced
this pull request
Apr 10, 2024
* hyprpm: only clone the required history * hyprpm: don't include tracy when building headers in release mode * chore: remove old, commented-out code See #4585 (comment) * chore: format code properly
lisuke
pushed a commit
to lisuke/Hyprland
that referenced
this pull request
Apr 15, 2024
* hyprpm: install headers locally * oopsie
lisuke
pushed a commit
to lisuke/Hyprland
that referenced
this pull request
Apr 15, 2024
* hyprpm: only clone the required history * hyprpm: don't include tracy when building headers in release mode * chore: remove old, commented-out code See hyprwm#4585 (comment) * chore: format code properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @zakk4223 @DreamMaoMao @fufexan
hyprpm will now install headers locally to
$XDG_DATA_HOME/hyprpm/headersRootShould completely eliminate duplicate headers / system headers issues.
hyprpmwill now refuse to use system headers altogether:Hyprland/hyprpm/src/core/PluginManager.cpp
Lines 285 to 290 in d0bfa56
They are unreliable all things considered and to be frank who cares.
Bonus: no more asking for password to install headers.
Needs some testing, seems to pass my short tests.